feat(canton): return extended payload from signablePayload #8337
Open
feat(canton): return extended payload from signablePayload #8337
Conversation
derranW26
force-pushed
the
WP-8187-investigate-txintentmismatch-for-canton
branch
3 times, most recently
from
d5c7249 to
0621452
Compare
Contributor
derranW26
force-pushed
the
WP-8187-investigate-txintentmismatch-for-canton
branch
from
0621452 to
8b0cbf7
Compare
derranW26
changed the title
Override signablePayload in Transaction and WalletInitTransaction to return the full extended binary payload (transaction metadata + hash) instead of just the raw hash. This ensures signableHex matches what the HSM signs, fixing TxIntentMismatch errors. Ticket: WP-8187
derranW26
force-pushed
the
WP-8187-investigate-txintentmismatch-for-canton
branch
from
8b0cbf7 to
3bdc436
Compare
Contributor
1 similar comment
Contributor
Contributor
2 similar comments
Contributor
Contributor
ravibitgo
approved these changes
Apr 10, 2026
Contributor
ravibitgo
left a comment
ravibitgo
left a comment
There was a problem hiding this comment.
What is the release plan for this? WP changes are also needed for this, else signing will break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-8187